[RFC] lp:// should use https://code.launchpad.net

John Arbash Meinel john at arbash-meinel.com
Wed Apr 11 15:12:34 BST 2007


It seems that if you use http://code.launchpad.net you get a redirect.

$ bzr checkout lp:bzr-pack-indices pack_indices
http://code.launchpad.net/bzr-pack-indices/ is redirected to
https://code.launchpad.net/bzr-pack-indices/

So I think we should just make it https:// to start with, so that we
don't get weird "redirected" messages.

Thoughts?

John
=:->

PS> The change is simple enough:
=== modified file 'bzrlib/plugins/launchpad/lp_indirect.py'
--- bzrlib/plugins/launchpad/lp_indirect.py     2007-01-26 04:44:10 +0000
+++ bzrlib/plugins/launchpad/lp_indirect.py     2007-04-11 14:12:06 +0000
@@ -34,9 +34,9 @@
 def launchpad_transport_indirect(base_url):
     """Uses Launchpad.net as a directory of open source software"""
     if base_url.startswith('lp:///'):
-        real_url = 'http://code.launchpad.net/' + base_url[6:]
+        real_url = 'https://code.launchpad.net/' + base_url[6:]
     elif base_url.startswith('lp:') and base_url[3] != '/':
-        real_url = 'http://code.launchpad.net/' + base_url[3:]
+        real_url = 'https://code.launchpad.net/' + base_url[3:]
     else:
         raise errors.InvalidURL(path=base_url)
     return get_transport(real_url)




More information about the bazaar mailing list