[RFC] Conditionalize format warnings

Martin Pool mbp at sourcefrog.net
Tue Apr 10 04:41:56 BST 2007


On 4/7/07, Matthew D. Fuller <fullermd at over-yonder.net> wrote:
> On Fri, Apr 06, 2007 at 01:45:49PM -0500 I heard the voice of
> John Arbash Meinel, and lo! it spake thus:
> >
> > You can use a "LocationConfig". As long as it has a location and a
> > ".get_user_config()" member.
>
> Well, the difficulty there is that by the time we get into
> _check_supported(), we're a couple steps down the stack from where we
> have any of that information.  I fiddled a little bit with trying to
> pass stuff down that deep, but I couldn't get it all the way to
> working, and it felt ugly as sin even as far as I got

_check_supported gets passed a parameter 'basedir' (a url), which
should be enough to find the location's config.  I think it's
reasonable this code be given a url rather than a BzrDir object
because we could want to check if the bzrdir should be opened before
constructing that object.

-- 
Martin



More information about the bazaar mailing list