[MERGE] apply_inventory_delta

[John Arbash Meinel]

John Arbash Meinel has voted +1.
Status is now: Approved
Comment:
How does this handle changing the executable bit? Just that the new 
entry has ie.executable = True/False?

+        :param changes: The list of tuples"""

The """ should be on a line of their own.

Also, I find it more obvious if it was:

:param changes: The list of changes [(old_path, new_path, file_id, ie)]

I realize you document it in the text. But when I'm looking for the 
signature of a parameter, I usually look directly at its :param: 
statement.

It looks like their might be a bug in your implementation if you rename 
a directory, and one of the children of that directory.
(mv dir => dir2, mv dir/child => other)

While you probably can't do this with a single command, I'm sure 'merge' 
can do it.

I guess it would 'just work' if you got the child move before the 
directory. Is that handled by the sorted()?

I would guess there are ways to pass an illegal delta. Should this 
command trap for this case? (I'm thinking that a first-pass dirstate 
implementation might just trust the caller, and DirState doesn't have 
the same built-in constraints that Inventory has)

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C460822FC.1070902%40utoronto.ca%3E