Test suite broken by strace in bzr.dev

[Olexandr Byelchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins пишет:
> On Wed, 2007-03-28 at 09:47 -0400, Aaron Bentley wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi all,
>>
>> Something funky is happening with the strace tests.
>>
>> $ ./bzr selftest test_str
>>        bzr: /home/abentley/bzr/bzr.ab.integration/bzr
>>     bzrlib: /home/abentley/bzr/bzr.ab.integration/bzrlib
>>
> 
> I've noticed this, will investigate. Its probably a rogue signal handler
> from another test (bzr selftest strace works fine).
> 
> just kill -CONT bzr to resume the tests.

BTW, running selftest on win32 on bzr.dev revno.2383 I got traceback:

    ret = run(*run_argv)
  File "C:\Temp\bzr.dev\bzrlib\commands.py", line 296, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "C:\Temp\bzr.dev\bzrlib\builtins.py", line 2377, in run
    numbered_dirs=numbered_dirs,
  File "C:\Temp\bzr.dev\bzrlib\tests\__init__.py", line 2068, in selftest
    numbered_dirs=numbered_dirs)
  File "C:\Temp\bzr.dev\bzrlib\tests\__init__.py", line 2033, in run_suite
    result = runner.run(suite)
  File "C:\Temp\bzr.dev\bzrlib\tests\__init__.py", line 518, in run
    test.run(result)
  File "C:\Python25\lib\unittest.py", line 424, in run
    test(result)
  File "C:\Python25\lib\unittest.py", line 428, in __call__
    return self.run(*args, **kwds)
  File "C:\Python25\lib\unittest.py", line 424, in run
    test(result)
  File "C:\Python25\lib\unittest.py", line 428, in __call__
    return self.run(*args, **kwds)
  File "C:\Python25\lib\unittest.py", line 424, in run
    test(result)
  File "C:\Python25\lib\unittest.py", line 281, in __call__
    return self.run(*args, **kwds)
  File "C:\Temp\bzr.dev\bzrlib\tests\__init__.py", line 1055, in run
    if not feature.available():
  File "C:\Temp\bzr.dev\bzrlib\tests\__init__.py", line 2262, in available
    self._available = self._probe()
  File "C:\Temp\bzr.dev\bzrlib\strace.py", line 79, in _probe
    if e.errno == errno.ENOENT:
NameError: global name 'errno' is not defined

bzr 0.16.0dev0 on python 2.5.0.final.0 (win32)
arguments: ['bzr', '--no-plugins', 'selftest']

** please send this report to bazaar at lists.ubuntu.com


Trivial fix to add import errno at the beginning of module:

=== modified file 'bzrlib/strace.py'
- --- bzrlib/strace.py    2007-03-27 07:37:12 +0000
+++ bzrlib/strace.py    2007-03-30 01:00:31 +0000
@@ -17,6 +17,7 @@

 """Support for running strace against the current process."""

+import errno
 import os
 import signal
 import subprocess


[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGDJ1bzYr338mxwCURAtJWAJ9v1yMkBAE8CJ0/4W2YBW43u1+2agCffDsu
Cfx3Uxbyu6uYD2+hxryY4kw=
=7lTE
-----END PGP SIGNATURE-----