[Fwd: Re: RFC: ERROR: Unsupported branch format (improve message)]

[John Arbash Meinel]

Just forwarding it to the list so it doesn't look like I merged
something without getting another +1. :)

John
=:->


-------- Original Message --------
Subject: Re: RFC: ERROR: Unsupported branch format (improve message)
Date: Fri, 23 Mar 2007 08:04:49 +1100
From: Martin Pool <mbp at sourcefrog.net>
To: John Arbash Meinel <john at arbash-meinel.com>
References: <fy7xfuau.fsf at cante.net> <4602922A.3030109 at arbash-meinel.com>

On 3/23/07, John Arbash Meinel <john at arbash-meinel.com> wrote:

> === modified file 'bzrlib/errors.py'
> --- bzrlib/errors.py    2007-03-15 23:24:59 +0000
> +++ bzrlib/errors.py    2007-03-22 14:25:43 +0000
> @@ -532,7 +532,7 @@
>
>  class UnsupportedFormatError(BzrError):
>
> -    _fmt = "Unsupported branch format: %(format)s"
> +    _fmt = "Unsupported branch format: %(format)s\nPlease run 'bzr upgrade'"
>
>
>  class UnknownFormatError(BzrError):

+1, but i would also remove the word "branch" from the message since
in Jari's case it's a repository not a branch (i think).

Also in general these would be clearer if they give the path - people
might wonder how init can complain  about an existing format;
presumably because of a containing bzrdir.

-- 
Martin