[MERGE] Remove Branch.get_root_id
John Arbash Meinel
john at arbash-meinel.com
Thu Mar 29 00:20:00 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> John Arbash Meinel has voted +1.
>>> Status is now: Approved
>>> I agree with you.
>>> This should have a NEWS entry about bug 96847
> I'm loathe to call this a bugfix so, what about something like this:
> IN DEVELOPMENT
> * Deprecate Branch.get_root_id() because branches don't have root
> ids, rather than fixing bug #96847. (Aaron Bentley)
>>> Also, I would like to wait until we know why James Henstridge wanted to
>>> use Branch.get_root_id()
> Okay. Though considering that Branch.basis_tree().get_root_id() is
> functionally equivalent and less buggy, I really don't see what he would
> want it for.
Good enough for me. And Robert's comment about bzr-avahi is enough for
me to +1 your fix.
We can mark the bug as rejected, but I would like to reference it
somehow in NEWS, so that people can read a discussion on it.
If this is a regression in 0.15 it might be worth back-porting.
Otherwise I don't care.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar