[MERGE] Test suite overhaul from the hpss branch

[Robert Collins]

On Wed, 2007-03-28 at 16:37 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> 
> ...
> 
> >> I'm not really sure about using tree.bzrdir.root_transport() to access 
> >> the "remote" working tree. Since we at least defined working trees as 
> >> being local only... Is this because you want to support MemoryTree?
> >> At least some explanation would be good.
> > 
> > Where is this? tree.bzrdir.root_transport() is always local [to the
> > tree], not remote - tree.branch.bzrdir.root_transport() could be remote.
> > 
> > -Rob
> 
> === modified file bzrlib/tests/branch_implementations/test_branch.py
> - --- bzrlib/tests/branch_implementations/test_branch.py
> +++ bzrlib/tests/branch_implementations/test_branch.py
> @@ -118,12 +118,10 @@
..
> 
> Are 2 locations. (self.build_contents() might be an alternative).
> 
> It may just be that you wanted a safe way of writing bytes, rather than
> using 'file().write()'.
>
> And I certainly support getting rid of file().write(). But using
> tree.bzrdir.root_transport.put_* doesn't seems like a proper alternative.

I agree.

> 
> Also:
> - -        self.build_tree(['a/one'])
> +        self.build_tree(['one'], transport=wt_a.bzrdir.root_transport)
>          wt_a.add(['one'])
>          wt_a.commit('commit one', rev_id='1')
> - -        self.build_tree(['a/two'])
> +        self.build_tree(['two'], transport=wt_a.bzrdir.root_transport)
> 
> I'm not sure what you are trying to do. Is it that you don't like having
> 'a/' there. Or is it that 'root_transport' is sometimes not a local
> directory.
> 
> If so, does this mean we are trying to support having a WT that aren't
> local disk? (The only one I can think of is MemoryTree).
> 
> But I know DirState won't work as a MemoryTree, since it is *very*
> focused on everything being local disk.

I think its crack from earlier efforts in the hpss branch.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070329/ab77c320/attachment-0001.pgp