aaron.bentley at utoronto.ca
Mon Mar 26 20:46:04 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
This patch implements MutableTree.apply_inventory_delta, which should
replace the need for WorkingTree._write_inventory. It was based on my
knowledge of TreeTransform's needs and Robert's knowledge of dirstate's
I say "should" advisedly-- as it turns out, smart_add_tree() has
different requirements. If its "save" parameter is False, then the
working tree inventory is modified, but not written to disk.
This seems like a pretty bad idea to me. It ties us to the inventory
representation that we want to move away from. Can we do something
Simply deprecating the "save" parameter won't work, because the "save"
parameter is also used for doing dry runs. So it seems like the best
option is to deprecate "save", and replace it with "save_inventory" or
something similar, which would leave the inventory in a pristine state
after a dry run.
I've tried disabling this functionality, and it seems like none of bzr
itself requires it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 31917 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070326/72035772/attachment-0001.bin
More information about the bazaar