[PATCH] Fix for osutils.rmtree failure on Windows with Python 2.5

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> Henri Wiechers wrote:
>>>> The behavior of shutil.rmtree was changed slighlty in Python 2.5. On
>>>> Windows, it will sometimes raise a WindowsError where previously it
>>>> would raise an OSError. This was
>>>> causing test_osutils.TestOSUtils.test_rmtree to fail.
>>>>
>>>> Here is a patch that should fix that.
>>>>
>>>> Thanks,
>>>> Henri
>>> It seems there were 2 +1's for the patch in Bundle Buggy, but no
>>> comments on the mailing list.
>>> http://bundlebuggy.aaronbentley.com/request/%3Ca5f499c70611021329k2fba1438h4ad07d5b0d44e16e@mail.gmail.com%3E
>>>
>>> So I'll go ahead and queue this up for merge.
>>>
>>> Also, Aaron, I thought you were going to have BB send emails to the
>>> mailing list. What happened to that? It feels weird to merge things that
>>> have been approved, but haven't had any actual discussion. (Though I'm
>>> sure I'll get used to it :)
> 
> BB did send emails to the list.  Mine was on Nov 9, message-id:
> <20061109143320.7098AA8860 at vm1.unixshell.com>
> 
> Martin's was Nov 10, message-id:
> <20061110071439.63DAAA8870 at vm1.unixshell.com>
> 
> Aaron

Weird, I didn't get either one of these messages. Has anyone else been
receiving BB emails? I suppose it is possible that they are getting
filtered in a weird way.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFVzO7JdeBCYSNAAMRAiy5AJ0aau+PTEH/LViZBA99z66azscL7QCgri3T
mFkMcOtstUKraTrbSdkGq3U=
=DFHI
-----END PGP SIGNATURE-----