[MERGE] Cleanup and test Lock objects

[Alexander Belchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel пишет:
> Alexander Belchenko wrote:
\>> One more thing.
>> Usually I have pywin32 installed, and ctypes too.
>> It will be great if we have the way to test both implementations
>> in one selftest run, without manual hiding/renaming/uninstalling pywin32.
>> What you think about?
>>
>> May be we can do in similar way as with different http transports,
>> and test each available lock implementation by explicit name.
>> In this case (IIUC) each lock implementation should have their
>> unique name for direct access from test code.
> 
> Well, they do have explicit names, but I realize they aren't always
> enabled. I can refactor it a bit more so we end up with a list of
> possible lock classes.
> 
> Either that, or we drop the pywin32 one entirely, and just make it a
> strict dependency on ctypes. Then we only have 2 lock objects. ctypes
> for win32, and fcntl everywhere else (including cygwin).

I think we need to drop pywin32 sooner or later.
Because Robert starts process of including C-extensions in bzr codebase
it have sense to write win32 locks handling as C-extension,
and keep ctypes variant as pure python implementation.

Dropping pywin32 has good side effect: it's means that Python 2.5 has
all major libraries for bzr inside. I remember Wouter and Vincent ask me
about minimal windows environment. If we drop pywin32 then minimal
windows environment to run and test bzr will be very simple: only Python 2.5.

[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF+Dq/zYr338mxwCURAq6+AJ4juJJrFk5kqPJ64MoiYzBwZO6QZwCfdJMh
b48LsCCbPuTg6rl4QrN6wdQ=
=FeVv
-----END PGP SIGNATURE-----