[MERGE] fixes for selftest on win32 (part 2) v2
John Arbash Meinel
john at arbash-meinel.com
Tue Mar 13 19:35:25 GMT 2007
John Arbash Meinel has voted +1.
Status is now: Approved
Comment:
Looks good to me. LockError.__init__() should be calling
BzrError.__init__(self), but it isn't like it did it before your fixes.
I also would like to see a comment like:
# Python 2.5 uses a slot for Error.message, so use a different variable
# name so it is exposed in self.__dict__
To explain why we don't want to use 'message'.
(Side note: I'd really like something like assertRaisesMsg, which checks
the str() form of the exception. I know we've discussed having an
assertRaises that returns the exception object, so you can inspect it.)
For details, see:
http://bundlebuggy.aaronbentley.com/request/%3C45F60B37.1000601%40ukr.net%3E
More information about the bazaar
mailing list