[MERGE] fixes for selftest on win32 (part 2)

John Arbash Meinel john at arbash-meinel.com
Tue Mar 13 19:32:47 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:

...

Well, that is part of the problem. I don't think _remote_path() *should*
be unix-only. It really can't be, since we should be setting up a SFTP
server on the local host, and allowing you to pass absolute paths to it.

> This is ugly. We try to test internal method t._remote_path() that implemented
> as unix-only. Ideally we should mockup the base URL of transport,
> but I don't have enough courage to write new mock server only for 1 test.
> 
> When I fix bzr+ssh I use this approach to create unix-like absolute URL:
> 
> unix_like = os.path.splitdrive(win_abs_path)[1]
> 
> in this case 'C:/some/path' becomes '/some/path' and still usable as absolute URL
> (within the same local drive). But changing testing server to this URL
> leads me to pass this 1 tests and fails 3 another tests.


I think it would be better to support paths like:

sftp://localhost/C:/some/path
bzr+ssh://localhost/C:/another/path

In win32 we should just understand that there will be a drive letter as
part of the url.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF9vxfJdeBCYSNAAMRAjerAJ9bqkJSeJh4bLVxaNiSMOWwRzPaugCfU4fA
A/2C/nScBt1CFmUEVCXcj0E=
=iR9v
-----END PGP SIGNATURE-----



More information about the bazaar mailing list