[MERGE] rand_chars() optimization

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> John Arbash Meinel has voted +1 (conditional).
> Status is now: Semi-approved
> Comment:
> I have to wonder why you are doing 20 characters in one pass, and 16 in
> the other. Also, I'd like to see it more like 50,000 rather than
> 100,000. It just seems that you have a fairly fast system, and it is
> still above the 1s target time.

This patch, like most optimizations, reduces legibility.  So far, I
haven't seen any evidence that it makes any Bazaar operation observably
faster.  So to my mind, there's no justification for including it.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF9rYy0F+nu1YWqI0RAgw1AJ9W33BHpdxeg031zDvtvrkG9zxCFgCeOnqX
eydIwMefZFF5Yo2WX6Aeqi4=
=maq3
-----END PGP SIGNATURE-----