some fixes for selftest on win32
Alexander Belchenko
bialix at ukr.net
Sun Mar 11 20:10:16 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
John Arbash Meinel пишет:
> John Arbash Meinel has voted +1 (conditional).
> Status is now: Approved
> Comment:
> I don't think we need an "if sys.platform == win32". We can just always
> set LANGUAGE, LANG, and LC_ALL to 'C'.
>
> It doesn't break anything to do so, and I would really prefer to avoid
> platform specific behavior whenever possible.
>
>
> And I think the test_external_diff_binary_lang_c can just do
>
> old_env = {}
> for lang in ('LANG', 'LC_ALL', 'LANGUAGE'):
> old_env[lang] = osutils.set_or_unset_env(lang, 'C')
>
> and then later do:
>
> for lang, old_val in old_env.iteritems():
> osutils.set_or_unset_env(lang, old_val)
Changed as you suggested. And submitted.
Attached patch for reference.
[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFF9GIozYr338mxwCURAnGxAKCTIu2HDoJOM3r+WoIawRlGvfXLcQCdE+GA
wgvg5rjabb94NP8EhFl1EDE=
=BMkF
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: selftest.win32-v2.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070311/a58bbf8a/attachment-0001.diff
More information about the bazaar
mailing list