[MERGE] bzrlib.osutils fixes

Dmitry Vasiliev dima at hlabs.spb.ru
Fri Mar 9 09:03:09 GMT 2007


John Arbash Meinel wrote:
> Some small things....
> 
> _directory_kind was really a misfeature. We were trying to re-use the 
> same string object, but it turns out that python automatically interns 
> any strings that look like identifiers (\w+). I think the code would be 
> a lot clearer if we just used 'directory' everywhere like we use 'file'.
> 
> I understand why tuple versus list doesn't matter, (because we just 
> re-generate it as a different tuple later) but it may be better to have 
> an explicit comment about it.

Done in the attached version.

-- 
Dmitry Vasiliev <dima at hlabs.spb.ru>
http://hlabs.spb.ru
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: osutils.bundle
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070309/074de605/attachment.diff 


More information about the bazaar mailing list