John Arbash Meinel
john at arbash-meinel.com
Wed Mar 7 22:21:23 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Aaron Bentley wrote:
> WorkingTree.extract was built for Inventory-based trees, but is now
> being used with dirstate-based trees. As a result, it fails if the
> dirstate is dirty.
> This patch fixes the bug by unconditionally flushing dirty state. Not
> the most correct solution, but certainly a simple one.
DirState.save() is actually a no-op if not modified, so flush() should
be fairly cheap.
The only real cost is if something is directly accessing tree.inventory,
since that needs to be regenerated after a flush. (I'm not sure why, but
that is the current code).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar