[PATCH][Bug 86451]Normalise path separators in ignore patterns

John Arbash Meinel john at arbash-meinel.com
Mon Mar 5 20:58:49 GMT 2007


John Arbash Meinel has voted +1.
Status is now: Semi-approved
Comment:
We don't leave extra whitespace around []:
+        name_pattern_list = [ globbing.normalize_pattern(x)
+            for x in name_pattern_list ]

I would typically write that as:

name_pattern_list = [globbing.normalize_pattern(p)
                      for p in name_pattern_list]


Also, the reason you see multiple lines as "changed" for the 
"text_regex" is because of how our diff algorithm works. It is a 
specific limitation of PatienceDiff. I can go into details if you want, 
but the basic answer is because the intermediate lines are not unique 
(they are the same as other lines that are marked as 'changed', and they 
are surrounded by changed lines. There are lots of cases where this is 
helpful because it doesn't accidentally match 'else:' lines.



For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C45E7DB06.1050102%40gmail.com%3E



More information about the bazaar mailing list