[merge] push and pull to use Result objects
Aaron Bentley
aaron.bentley at utoronto.ca
Tue Feb 27 21:27:33 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
> This changes them to instead return a Result object with various fields.
> This is also passed to the relevant hooks, which simplifies their
> interface. (This is not a compatibility problem because those hooks
> were added in this release.)
I don't see a difference between PushResult and PullResult. Do you
think a difference is justified?
Also, I agree with John that it would be nice if all the members were
defined in the class definition-- otherwise, reuse is kind of hard,
because you never know whether you've set all the right properties in
the object.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFF5KJF0F+nu1YWqI0RAv5kAJ9xcvubAGowXp8lkhXymlBGHjlaIACaAtSq
efcLfN8siW7SMj4qOuRVfrs=
=1vVt
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list