_iter_changes API changes...
aaron.bentley at utoronto.ca
Mon Feb 26 00:33:03 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Robert Collins wrote:
> On Sun, 2007-02-25 at 18:28 -0500, Aaron Bentley wrote:
>> I'm not so keen on *only* allowing paths to be supplied, but if either
>> paths or file_ids could be supplied, that would be fine with me. While
>> no callers currently use a different algorithm for translating
>> user-supplied paths into filenames, commit uses a different algorithm in
>> which supplying a pathname causes both the children of the path, and its
>> ancestors to be selected.
>> That is, "foo/bar/baz" would select not only "foo/bar/baz/qux", but also
>> "foo" and "foo/bar". So if we want to use iter_changes in commit, this
>> would be a serious drawback.
>> The other issue is that the ids_across_trees algorithm seems very much a
>> UI thing. I think our low-level interfaces should support more
>> precision than that.
> Given the time constraints to get this into the current release, I
> propose that we keep the interface private - including the reporter
> interface (library users can stay with Tree.compare for now), and we
> extend it to do what commit needs.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar