[PATCH] Search user plugin directories before site plugin directories

[Robert Collins]

On Fri, 2007-02-23 at 14:24 -0600, John Arbash Meinel wrote:

> You broke the fact that we used to load in a specific order. You didn't
> break the fact that we were loading site-wide plugins before user
> plugins and skipping user plugins.

> The supplied patch loads user plugins preferentially to site-wide
> plugins, but doesn't do anything about specific plugin load order. (If
> you have site "foo" and user "foo" you know user "foo" will be loaded,
> but you don't know whether it will load before or after site "bar" or
> site "baz")

I dont think a specific plugin order is useful: it was never well
defined (certainly never tested for). But if really wanted we can do it.
If its for getting 'a decorates b' working consistently, I dont think th
e load order is the right tool.

> So we need to discuss if we want to do anything about plugin ordering,
> but as a first step, we would at least allow users to install a plugin
> and have it supersede the site-wide one.

I think thats a bad idea. IIRC the reason we load from the master
library, then the user supplied path, is so that system supplied
plugins, which can be upgraded in lockstep with bzr because we ship them
in the tarball, will always be the version loaded.

I actually think the bug that occured here for Jonathon was that the
debian package installed a non-core plugin in the system plugins dir,
not in an extra path search by bzr (e.g. /etc/bazaar/plugins/pqm as a
symlink to /usr/share/lib/bzr-pqm).

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070224/264cc167/attachment-0001.pgp