[PATCH] Search user plugin directories before site plugin directories

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> Aaron Bentley has voted -1.
>> Status is now: Vetoed
>> Comment:
>> This is the wrong way to do it.  Plugins can override existing commands,
>> so user plugins should be searched last, so that they can override
>> commands supplied by system-wide plugins.
> 
> You misunderstand how this code works. This is changing the python
> import path.

If you think that's so, it's you who misunderstands.  This is
determining the plugin path, not sys.path.

> And in the import path the *first* entry wins. Not the last
> one.

This is the plugin path, not the import path, and so we get to determine
how it works.  I think we should:

1. generate a list of all plugins
2. where there are name conflicts, choose the last-found plugin
3. load all plugins in the list.

> This should be re-opened and accepted, rather than vetoed.

I disagree.  Applying this change would break our existing override
behavior.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF3xZp0F+nu1YWqI0RAhomAJ9IjZp/RwHwrtG3h0PX2lNo4PNDuACggEoN
+xAjjJNIF4zNo4Yjhre+EwQ=
=XFj/
-----END PGP SIGNATURE-----