[PATCH] Search user plugin directories before site plugin directories
aaron.bentley at utoronto.ca
Fri Feb 23 16:29:29 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> Aaron Bentley has voted -1.
>> Status is now: Vetoed
>> This is the wrong way to do it. Plugins can override existing commands,
>> so user plugins should be searched last, so that they can override
>> commands supplied by system-wide plugins.
> You misunderstand how this code works. This is changing the python
> import path.
If you think that's so, it's you who misunderstands. This is
determining the plugin path, not sys.path.
> And in the import path the *first* entry wins. Not the last
This is the plugin path, not the import path, and so we get to determine
how it works. I think we should:
1. generate a list of all plugins
2. where there are name conflicts, choose the last-found plugin
3. load all plugins in the list.
> This should be re-opened and accepted, rather than vetoed.
I disagree. Applying this change would break our existing override
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar