[MERGE] Add a get_login method to UIFactory and test get_password

Martin Pool mbp at canonical.com
Tue Feb 20 19:46:25 GMT 2007


Martin Pool has voted +1.
Status is now: Semi-approved
Comment:
ok

+    We pretend to be the real stdin by redirecting the fileno method so 
that
+    getpass.getpass can succeed changing the echo mode of the real
+    stdin. More precisely, getpass change the echo mode via tcsetattr 
which
+    requires a file descriptor, once the user have entered its password 
the
+    echo mode is restored (this is garanteed by a try-finally). So 
basically
+    the risk for the tester is to lose ist echo if he attemps to type 
some
+    characters *while* the echo is disabled.

"his echo" maybe?

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3Cm2odnp1cjl.fsf%40bigmamac.local%3E



More information about the bazaar mailing list