[MERGE] Bugfix #85599: ``bzr init`` works with unicode argument LOCATION

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Fix and test.
> 

I've also seen similar problems when using the bzr+ssh:// transport,
since there are some code paths which keep track of the current location
as a Unicode string, and pass it as a relpath() rather than using the
url-encoded string.

One that I've seen is:

parent, basename = os.path.split(user_path)
parent_transport = get_transport(parent)
parent_transport.mkdir(basename)

It would be better to do this as:

transport = get_transport(user_path)
transport.mkdir('.')

That was a side note, +0.5 on your patch. The main reason I mention it
is because it is actually BzrDir.create() where the real bug lies.
Because it is directly passing a Unicode string to t.mkdir().

I'm very happy to see a test for 'bzr init', but I think adding a BzrDir
test for BzrDir.create() with a unicode path would also be useful.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF1zW7JdeBCYSNAAMRAq+4AJ97ax40w2y5l2CkhYONKohOsaPfxACg1DjX
KnqbjM7W2acrmQ+2j/w1Avk=
=GR5J
-----END PGP SIGNATURE-----