[MERGE] switch to using utf-8 revision ids

Robert Collins robertc at robertcollins.net
Wed Feb 14 02:48:37 GMT 2007


On Tue, 2007-02-13 at 08:27 -0600, John Arbash Meinel wrote:
> 
> -        self.control_files.put_utf8(
> +        rev_history = [osutils.safe_revision_id(r) for r in
> rev_history]
> +        self.control_files.put_bytes( 

This stood out to me. It might be better to have

osutils.safe_revision_ids() - then you have

rev_history = osutils.safe_revision_ids(rev_history)

And this should have much less function call overhead.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070214/ee211606/attachment.pgp 


More information about the bazaar mailing list