[merge] split out repository formats

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> OK so here's an updated version.  

I really wish this hadn't gone in so soon.  It's going to play havoc
with by-reference-trees, which introduces a new repository format.

> @@ -1987,18 +1987,29 @@
>      e.g. BzrDirMeta1 with weave repository.  Also, it's more user-oriented.
>      """
>  
> -    def register_metadir(self, key, repo, help, native=True, deprecated=False):
> +    def register_metadir(self, key, repo, help, native=True, deprecated=False,
> +            repo_module='bzrlib.repository'):

I think this is a poor choice, because by the time branch6 and
by-reference trees go in, it's going to look like this:

    def register_metadir(self, key, repo, help, native=True,
                         deprecated=False,
                         repo_module='bzrlib.repository',
                         branch_format=None,
                         workingtree_format=None):

And by extension, it would turn into

    def register_metadir(self, key, repo, help, native=True,
                         deprecated=False,
                         repo_module='bzrlib.repository',
                         branch_format=None,
                         branch_module='bzrlib.branch',
                         workingtree_format=None,
                         workingtree_module='bzrlib.workingtree'):

I think it would be better if register_metadir could take
fully-qualified class names instead, i.e.

register_metadir('knit', 'bzrlib.repofmt.knitrepo.RepositoryFormatKnit1',
'Knit format 1'
branch_format='bzrlib.branch.BranchFormat5',
workingtree_format='bzrlib.workingtree.WorkingTreeFormat3')

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFF0gGf0F+nu1YWqI0RAsK2AJ9TLmzuDE17fw/zTKsjSr6B6ZeahACeMjdD
AJ2PMWXfEJF7bFd+I3ylVzM=
=MJeL
-----END PGP SIGNATURE-----