[RFC] locking decorators and iterators

Aaron Bentley aaron.bentley at utoronto.ca
Tue Feb 13 15:06:20 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
> 
> Looking at the output of which entries failed after the new decorators,
> though, I can see that 'revision_trees' and 'get_deltas_for_revisions'
> are both things that should require a lock, and that they are both
> iterators which can actually help performance (being able to read ahead,
> but return things as they are available/in the requested order)

Given that repositories are append-only, do those really need locks?
Read locks just give you caching, anyhow.

But maybe it would be enough to assert that a lock is held inside the
iterator.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFF0dPs0F+nu1YWqI0RAhSAAJ0XOp1T7+3sweA7CURmQn0gDJuE1gCaArM1
s4hyBFaoEXkl3r7JVzLMyOw=
=ou9F
-----END PGP SIGNATURE-----



More information about the bazaar mailing list