bzr add .bzr/

[Alexander Belchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthias Rahlf пишет:
> Hi,
> 
> $ bzr add .bzr/
> bzr: ERROR: Cannot operate on <bzrlib.add.FastPath object at 0xb75826ec>
> because it is a control file
> 
> It seems, FastPath is missing a __str__() method.
> 
> I'm not familiar with the development process. Should I file a bug
> report or is there a friendly developer who would adopt my patch?

Our development process use TDD, so you need also write the unit test
for this bug.
I think blackbox test will be good enough.

You could find blackbox tests for 'add' command in bzrlib/tests/blackbox/test_add.py.
Use some test as example, or ask for help.

> 
> === modified file 'bzrlib/add.py'
> --- bzrlib/add.py	2006-11-10 21:06:11 +0000
> +++ bzrlib/add.py	2007-02-11 01:34:40 +0000
> @@ -167,6 +167,9 @@
>      def __hash__(self):
>          return hash(self.raw_path)
>  
> +    def __str__(self):
> +        return self.raw_path
> +
>  
>  def smart_add_tree(tree, file_list, recurse=True, action=None, save=True):
>      """Add files to version, optionally recursing into directories.
> 

Your patch OK for me.

If you wish to work on bzr codebase, please read HACKING guide in the
bzr.dev source tree.

Alexander

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF0H30zYr338mxwCURAsFFAKCXFCfL9u74sHxnzRtBkaCiZma2rwCfe0Y4
rxDn6HVOFyjSoKzQpdt8ES4=
=bmgJ
-----END PGP SIGNATURE-----