[MERGE] Only sign 8-bit strings
John Arbash Meinel
john at arbash-meinel.com
Thu Feb 8 16:41:41 GMT 2007
The attached patch changes GPGStrategy.sign() so that it rejects Unicode
strings that are passed in.
This is both because it is conceptually more correct, and because it
seems there is a discrepancy in some versions of python. Where now doing
subprocess.Popen.communicate(u'foo') will write out the raw UCS4 bytes.
It turned up mostly because of pqm-submit, which was passing Unicode
strings for the urls (because we read them from ConfigObject which
always returns Unicode, even though they should be 7-bit ascii urls).
I've updated pqm-submit because it was breaking the pqm (or at least the
web interface).
I realize this is an incompatible API, but the old one was incorrect, so
I don't think we need to deprecate it.
John
=:->
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gpg-8-bit-only.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070208/91e09223/attachment.diff
More information about the bazaar
mailing list