[PATCH] [Bug 83954] Error while using "bzr branch" through proxy

[John Arbash Meinel]

John Arbash Meinel has voted +1 (conditional).
Status is now: Semi-approved
Comment:
Can we just use a whitebox test on:
ProxyHandler.set_proxy() ?

And just do:

handler = ProxyHandler({'http':'http://joe:foo@bar.com')
request = urllib2.Request()
handler.set_proxy(request, 'http')
self.assertEqual('Basic ' + 'joe:foo'.encode('base64'),
                  request['Proxy-Authorization'])

Also, something seems missing in that if you don't have a password, it 
doesn't set up anything.

Anyway, I don't think we need to go down the road to full-scale tests 
just yet. We can just whitebox test the ProxyHandler class and make sure 
it sets the headers that we expect it to set.


For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3Cm2lkj8oltk.fsf_-_%40bigmamac.local%3E