[merge] split out repository formats
Martin Pool
mbp at canonical.com
Wed Feb 7 12:57:12 GMT 2007
On 6 Feb 2007, John Arbash Meinel <john at arbash-meinel.com> wrote:
> Martin Pool wrote:
> > This splits some old formats into a bzrlib.repofmt submodule, and allows
> > for them to be lazily loaded from there.
> >
> > I have a followon that moves the other formats but this is quite
> > textually (though not conceptually) large already.
> >
>
> I would have probably put the base class and the registry in
> bzrlib/repofmt/__init__.py, but this isn't a huge deal.
That might be good, but I don't think it has to necessarily be done at
the same time (and that would cause even more interface shaking). For
now I just wanted to shrink this file a bit.
> You also didn't mention a few other things that you did. Namely getting
> rid of InterWeaveRepo and changing bzrdir.open_repository() for certain
> formats to create_repository() for all formats.
>
> I think Robert brought up a reasonable concern about whether you could
> upgrade a Weave to a knit.
Just to confirm, I tested and you can. I had thought it could be
pruned, but I think we should add it back to allow for faster upgrades
from weaves to knits if anyone does still have them.
> There probably are not many people still using a Weave repo because of
> the warning. But then again has Dapper had an official upgrade to bzr?
> Because 0.8.2 was perfectly ok using Weave formats. And back in Nov I
> know some of the distro people were still using Weaves because they just
> hadn't needed to upgrade yet. (For small projects they work okay).
>
> So I really like the idea, but I feel your description of what is going
> on is incomplete, and I'm not sure if I've missed something in the large
> patch.
I'll put the weave->knit back in and send a better description in the
morning.
--
Martin
More information about the bazaar
mailing list