[MERGE] Add a way to specify a template commit message

James Westby jw+debian at jameswestby.net
Tue Feb 6 00:01:22 GMT 2007


On (05/02/07 12:29), John Arbash Meinel wrote:
> I'm pretty sure that msgfile = os.close() is bogus (I don't think it
> returns anything useful, and certainly it is never used).
> 
> I think it would be better to just do:
> 
> os.close(tmp_fileno)
> msgfile = None
> 
> ...
> if msgfile is None:
>     msgfile = file(msgfilename, "w")
> 
> Maybe at one point it was doing
> msgfile = os.fdopen(tmp_fileno)
> 

Hi John,

Attached is a bundle that I hope addresses both yours and Alexander's
concerns.

Thanks,

James

-- 
  James Westby   --    GPG Key ID: B577FE13    --     http://jameswestby.net/
  seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256
-------------- next part --------------
A non-text attachment was scrubbed...
Name: editmsg.diff
Type: text/x-diff
Size: 14363 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070206/f78a0dda/attachment-0001.bin 


More information about the bazaar mailing list