[MERGE] Add a way to specify a template commit message

James Westby jw+debian at jameswestby.net
Sun Feb 4 12:38:20 GMT 2007

On (04/02/07 07:29), Robert Collins wrote:
> Robert Collins has voted +1 (conditional).
> Status is now: Semi-approved
> Comment:
> The check for 'start_message != ""' seems wrong to me - an empty start 
> message is still a start message.

I was just following the lead of the template message code. That
excludes an empty template message. I can see that that might be
different though, you can save on the separator adding removing if it is
empty. I'll make the change as you add.

> Just checking for None appears 
> sufficient to me. Other than that, the test for using start_message 
> should be a separate test function, not an extension of the current one 
> - its a new test, and the mutter() call seems entirely spurious to me.

Again I was just following what was there. I was trying to be cautious
to avoid problems on things like win32. I'll factor out the code to do
the editor thing and make it a separate test.



  James Westby   --    GPG Key ID: B577FE13    --     http://jameswestby.net/
  seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256

More information about the bazaar mailing list