[BUG] Crash when doing status

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Nicholas Allen wrote:
> Hi,
> 
> I have my /etc directory under bzr control. I just tried to do a status
> and got the following stack trace:
> 
> bzr st

My best guess is that you had a file change to a symlink, or the other
way around.

But certainly this sort of thing shouldn't just trigger an assert, it
should at the very least give you a clean error.

(For example, this assert doesn't tell you what file is failing, or
really any relevant information. If it did:

assert kind[0] == kind[1] or None in kind, \
  'kind failure: %s, %s' % (kind, path)

You would at least be able to figure out what it was failing on.

But a better change would be:

if kind[0] != kind[1] and kind[0] is not None and kind[1] is not None:
  raise KindChange(path)

Which could tell you that the kind of a file changed, and you need to do:
bzr rm path
bzr add path

To get it working again.

John
=:_>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFv7qgJdeBCYSNAAMRAtn2AJ9KOxy3/fFiNSbxaBLaKNjUHKcegwCcCwWZ
tesxFDH0HerBl9IqAYzScj4=
=wfuQ
-----END PGP SIGNATURE-----