RFC: Possibility to re-edit last commit message

John Arbash Meinel john at arbash-meinel.com
Mon Jan 29 17:00:46 GMT 2007


Wichmann, Mats D wrote:
>> On ma, 2007-01-29 at 18:14 +0200, Jari Aalto wrote:
>>> The reason why "bzr ci --re-edit" is imporartant is that 
>> there are many
>>> non-native speaker's that make typos and grammar mistakes 
>> all the time.
>>> We just don't notice them but only after looking the message 
>> second time
>>> (after the commit is already happened).
>> In that situation, my approach would be two-fold: a) use a spell
>> checking editor and b) not worry about it much. :)
> 
> There are other kinds of mistakes.  I don't worry about it
> if I misspell something, but on occasion I've noticed I
> punched in the wrong bug number if I'm including a bug
> reference, and that is one I want to go back and fix :)
> 
> I liked the git syntax as noted by Matthieu:
> 
> 	Fyi, this is "commit --amend" in git.

I know of this syntax, but I think a separate function makes more sense.

I don't really know how "commit --amend" is implemented. But to me the
command "commit" is adding new stuff, and shouldn't be replacing the
existing stuff.

Hence the desire to name in "bzr recommit". Though we could call it "bzr
amend-commit" just as easily.

bzr change-commit
bzr fix-what-i-just-committed-by-accident
bzr i-didnt-really-mean-that


I'm curious how other people feel, though. Aside from "that is how git
does it", are there reasons to make it part of the commit command,
rather than a separate command with clearly distinct functionality? (You
wouldn't have 'bzr commit --uncommit', but maybe 'bzr commit --amend' is
reasonable)

John
=:->



More information about the bazaar mailing list