[merge] lookup branches through launchpad

[John Arbash Meinel]

John Arbash Meinel has voted +1 (conditional).
Status is now: Conditionally approved
Comment:
You need an extra line here, and it might be nice to add a comment to 
the class.
+from bzrlib.transport import get_transport
+from bzrlib.tests import TestCase, TestSkipped
+
+class IndirectUrlTests(TestCase):
+

Otherwise, I think that:

1) This is only provided by the plugin, which means it is clearly 
separated. I really like this.

2) The utility of being able to do "bzr branch lp:project/branch" is 
rather important. It may seems like a small thing, but I think it is one 
of those "Wow, this is really easy" things that will make people like 
it.

At the moment, it is a little incomplete, because I don't see a good way 
to get a non-mainline branch. The best I can come up with is:

"bzr branch lp:~user/+branch/project/branch"

It would be a lot better as just:
"bzr branch lp:~user/project/branch"

Or I would even prefer:
"bzr branch lp:project/~user/branch"
or
"bzr branch lp:project/user/branch"


So I think 'lp:project' is actually going to be one of the "killer" 
features, because it makes it trivial to see what is going on in a 
Launchpad hosted project. I think it is worthwhile to merge what you 
have already done, but I'm curious to see how you would like to 
"complete" it.

I also thought the idea (at one point) was to use the XMLRPC layer to do 
more of this. Which would let us translate "lp:project/user/branch" into 
any sort of url we wanted.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C20070126050436.GA14048%40sourcefrog.net%3E