RepositoryFormat/Repository split

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> (Tangentially) this is the sort of issue that makes me somewhat
> uncomfortable with the split between RepositoryFormat and Repository.

I have similar feelings.

I have been storing class variables on RepositoryFormats, to describe
format capabilities, but storing them on the Repository would work too.

> I think the only snag here is that instances of BzrDirFormat can have
> state, being a representation of the formats of the other objects that
> are held inside them.

Yes.  I should mention that I'm planning to expand the use of this.  For
nested trees, I need a new working tree format, so I plan to give
BzrDirFormat instances a working_tree_format.

I'm also working on a new branch format, and when that lands, it will
provide BzrDirFormat.branch_format.

I think if we wanted to, we could use strings rather than
RepositoryFormat instances as the BzrDir members.  I'm not sure it's a
big deal at this stage.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFsDqm0F+nu1YWqI0RAgfsAJ0SwnzVAkgl57NO/MmAH+eP0xh/xACfTwkg
cUXwi5pDKJaNlbYVamx8qkQ=
=rnSd
-----END PGP SIGNATURE-----