[MERGE] reject reserved revision ids Reply-To:

[Wouter van Heyst]

On Thu, Jan 11, 2007 at 12:32:48PM -0500, Aaron Bentley wrote:
> Hi all,
> 
> We seem to be agreed that revision ids ending with ':' should be
> reserved.  There are currently two such ids:
> 
> 'null:' (the null revision)
> 'current:' (the current on-disk state)
> 
> This patch causes all reserved ids to be rejected by versionedfiles,
> repositories, branches and trees.  Perhaps it doesn't cover every
> possible method, but it should cover enough that using a reserved id
> will lead to errors immediately.
> 
> Unfortunately, the test cases mean that API compatibility is not
> preserved-- we are adding a new requirement (to throw ReservedId), and
> plugins that implement branch, repository or tree will fail the test
> suite until they are updated.
> 
> I hope that this small incompatibility is permissible.  The alternative
> is much more complex.

The code itself looks good, but the change in behaviour it introduces is
something I'd typically want to make in the beginning of a cycle instead
of at the end. In any case where 3rd parties can break, giving them the
chance to shake things out is good.

I'd prefer this change to not go into 0.14, but +1 (with NEWS entry) for
0.15.

Wouter van Heyst
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070113/1b99f734/attachment.pgp