[MERGE] reject reserved revision ids

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

We seem to be agreed that revision ids ending with ':' should be
reserved.  There are currently two such ids:

'null:' (the null revision)
'current:' (the current on-disk state)

This patch causes all reserved ids to be rejected by versionedfiles,
repositories, branches and trees.  Perhaps it doesn't cover every
possible method, but it should cover enough that using a reserved id
will lead to errors immediately.

Unfortunately, the test cases mean that API compatibility is not
preserved-- we are adding a new requirement (to throw ReservedId), and
plugins that implement branch, repository or tree will fail the test
suite until they are updated.

I hope that this small incompatibility is permissible.  The alternative
is much more complex.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFFpnTA0F+nu1YWqI0RAlkPAJsGQ5cvMbzML7NPfpQTsY7ZeQNQCACfbGwk
21p/i5DXT1cbML93wJg6UFs=
=zHy9
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reject-reserved.patch
Type: text/x-patch
Size: 8045 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070111/c7e78960/attachment.bin