[MERGE] set_default deprecations, 2nd Edition

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> I was trying to comment on this and get a repeatable bb crash:

Hmm.  Okay, I guess I'll have to try it at home.

> It's trivial here but I would suggest having the deprecated method just
> call the new private one.

I agree that's a good policy.  I just neglected to do it because of the
way the changes evolved.  I can update it.

> Perhaps we should go towards the create*() methods being primarily on
> the format, not class methods on BzrDir?

It's possible.  One of the issues I was balancing was the fact that
BzrDir.create() does a bit more than BzrDirFormat.initialize(), so
they're not interchangeable.

I also find it useful in the test suite to be able to provide a format
*string*, rather than a format instance, so I wonder whether it would
also be useful for BzrDir.create_standalone_workingtree() et al.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFFo5/p0F+nu1YWqI0RAlBiAJ4hc1O1HO6g9l2bPAwekywCNXZR7ACfUYdF
DTFdHL7E4ox12F+uEbw9Atw=
=PF/k
-----END PGP SIGNATURE-----