[MERGE] enhanced mv command

Aaron Bentley aaron.bentley at utoronto.ca
Tue Jan 9 13:42:45 GMT 2007

Hash: SHA1

Marius Kruger wrote:

>     I have to say that it's kinda frustrating plowing through all these
>     unrelated changes in order to review this new mv thing.
> I'm sorry about that, I was told that the "errors." syntax should
> be used from now on and I'm one for fixing stuff immediately if
> they should be fixed. But I see your point.
> Do you want me to split it up so that we have a separate bundle
> to fixup all errors in bzrlib/workingtree.py ?

For mv, don't worry about it.  But in the future, yes, please keep
changes like that separate.

> I can't make up my mind how these doc strings should look
> (I'm going around in circles changing it),
> It is quite difficult to describe these tests in one line without
> almost exactly copying the method name.

I agree that meeting that standard can be awkward.  On the other hand,
it's expected by many tools, so it's best to conform.  Copying the
method name isn't the worst thing.

> Please tel me which one you would prefer (or give a better suggestion).
>     def test_mv_already_moved_file(self):
>         """Test bzr mv existing_file to new_file.
>         a is in the working tree, b does not exist.
>         User does mv a b; bzr mv a b
>         """

I like this one.

Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org


More information about the bazaar mailing list