[MERGE] FormatRegistry

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:

...

>>> v- I thought the whole point of passing "default" was because you wanted
>>> it to explicitly exist in the list. It seems you are changing it here,
>>> which means that if something changes the registered "default", it still
>>> won't use it.
> 
> I'm hoping this will be a temporary problem.
> 
> There's no legitimate reason to change the default.  The code that does
> is old code that is just trying to create a particular format, something
>  that is better-handled by doing TestCase.make_branch_and_tree and
> supplying a format parameter.
> 
> With the registry in place, I can update the old code, then deprecate
> Repository.set_default_format.


I would think that plugins might want to change the default. You don't
think so?


> 
>>> So other than wondering why you are hard-coding "default" +1.
> 
> Does that make sense?
> 
> Aaron

I'm not going to be very strict on this one. I think it is an
incremental improvement, even if I don't agree on all of the details.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFmwmTJdeBCYSNAAMRAo0EAKCelgPS4XnxRgfzJYKLNi1cGAzM/QCePVTi
wKT51/o9693v62tS+f7GoKc=
=SPXy
-----END PGP SIGNATURE-----