[MERGE] make local_time_offset() more reliable (bug 77588)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> John Arbash Meinel ?8H5B:
>>> John Arbash Meinel has voted +1.
>>> Status is now: Semi-approved
>>> Comment:
>>> Alexander- Can you say why you voted +0 instead of +1? It would help us
>>> understand what you were thinking.
> 
> Look at this code:
> 
> +        self.assertTrue(-86400 < offset < 86400)
> 
> I'm not expert in timezones so I'm not sure: is not to be here:
> 
> +        self.assertTrue(-86400 <= offset <= 86400)
> 
> ?
> 

Sure, I just didn't know why.

I'm not really concerned, because timezones should really only go +- 12
hours (with some small fudging because of Daylight savings time, etc).

If a timezone was actually configured to be +24 hours, I think we would
probably want it flagged.

I would actually like something more like +-15 hours, but I don't know
what a safe margin is for real-life.

But we can go either way. If you want, I can switch it, and then merge.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFmpp7JdeBCYSNAAMRAg/uAJ9ZUFl2LT3gncW2B5VE4FDoOlModQCePfc/
TY5vwpY8+y3AfEZUw8yuX9Q=
=3Wzg
-----END PGP SIGNATURE-----