[MERGE] make local_time_offset() more reliable (bug 77588)
John Arbash Meinel
john at arbash-meinel.com
Tue Jan 2 17:46:35 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Alexander Belchenko wrote:
> John Arbash Meinel ?8H5B:
>>> John Arbash Meinel has voted +1.
>>> Status is now: Semi-approved
>>> Alexander- Can you say why you voted +0 instead of +1? It would help us
>>> understand what you were thinking.
> Look at this code:
> + self.assertTrue(-86400 < offset < 86400)
> I'm not expert in timezones so I'm not sure: is not to be here:
> + self.assertTrue(-86400 <= offset <= 86400)
Sure, I just didn't know why.
I'm not really concerned, because timezones should really only go +- 12
hours (with some small fudging because of Daylight savings time, etc).
If a timezone was actually configured to be +24 hours, I think we would
probably want it flagged.
I would actually like something more like +-15 hours, but I don't know
what a safe margin is for real-life.
But we can go either way. If you want, I can switch it, and then merge.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar