[MERGE] Initialize before transfer for BzrDir.clone() and sprout()
John Arbash Meinel
john at arbash-meinel.com
Thu Dec 21 23:33:38 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The attached patch changes BzrDir.clone() and BzrDir.sprout() so that
they create the target branch and repository first, and then copy the
data into it.
The biggest effect of this, is to close
https://bugs.launchpad.net/products/bzr/+bug/45504
Which means that when people push new branches into Launchpad, hitting
^C doesn't totally mess them up. Which helps avoid bugs like:
https://bugs.launchpad.net/bugs/53340
and
https://bugs.launchpad.net/bugs/30576
There is still a short window where those can be triggered, but at least
it is *much* smaller now.
This also has an effect on 'bzr branch' so that the transfer can be
resumed by simply "cd target; bzr pull".
And as a side effect of the refactoring, it should fix:
https://bugs.launchpad.net/products/bzr/+bug/50582
But I didn't write tests for that, so I won't guarantee it.
I also removed the deprecated code from Branch.clone(). It was
deprecated it 0.8, and it seemed a reasonable time to clean it up.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFixnSJdeBCYSNAAMRAh8TAKDGZ1n/9lradVZLgtkq81y1x2blSACdFGy7
kZPVBT2uPQwcdZU36a1ZjPs=
=EbKH
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_push.patch
Type: text/x-patch
Size: 141821 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061221/59fd2c94/attachment.bin
More information about the bazaar
mailing list