BB Failure to submit

John Arbash Meinel john at arbash-meinel.com
Thu Dec 21 21:40:05 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I was trying to submit this text in the BB dialog:

Other than hard-coding "default", it looks good.

This looks like the 'if typestring == "default"' should just be removed,
along with the associated comment:
 def get_format_type(typestring):
     """Parse and return a format specifier."""
- -    if typestring == "weave":
- -        return bzrdir.BzrDirFormat6()
+    # Have to use BzrDirMetaFormat1 directly, so that
+    # RepositoryFormat.set_default_format works
     if typestring == "default":
         return bzrdir.BzrDirMetaFormat1()

If there are tests that depend on this (by overwriting defalt_format)
they probably should also be overwriting the default in the dictionary.


But when I tried, it kept giving me an "Internal Error".

When I cut down the text to just the first line, it seemed to work.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFiv81JdeBCYSNAAMRAluRAKDMH6gFsiorsuTntpnjJA21d0P1lQCfQXkQ
3Oec7QxIz4/Wx7sgg++rrww=
=7+/7
-----END PGP SIGNATURE-----




More information about the bazaar mailing list