[RFC] Commit Builder restructuring (Re: [RFC] letting the commit builder assign the file ids)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Jelmer Vernooij wrote:
>>> On Thu, 2006-12-21 at 09:29 -0500, Aaron Bentley wrote:
>>>
>>>> Jelmer Vernooij wrote:
>>>>
>>>>> Thoughts?
>>>> Could you explain why the bzr-svn generates new file ids at commit time?
>>>> Why doesn't it do that when you import a branch from bzr?
>>> Well, that's when it usually generates file ids.
> 
> Eh?  You mean it generates new file ids on import?  I thought that
> bzr-svn was able to roundtrip bzr data.
> 
> If it can, then it should be able to use that mechanism instead of
> generating new file ids.
> 
> If it can't, we should be aiming at that instead.

bzr-svn generates a file-id for every file. It is something like:

UUID-branch-path-REVNUM-file-path-in-branch

Where UUID is the svn uuid of the repository. branch-path is the path to
the base of the branch in the repository foo/trunk for example. REVNUM
is the first revision that introduced the file, and file-path is the
path underneath the branch.

So bzr-svn has its own set of file-ids.

- From what I've seen in general with bzr-svn, it is mostly trying to make
bzr accept what svn gives it, more than have svn reflect anything from bzr.

Which I can sort of understand. Considering you may be pulling from a
readonly upstream svn. And svn's model isn't quite as flexible.

Though if you are committing, you certainly could add a file property
which was its bzr file-id. And then you could check for that
preferentially to creating a new file-id. Being an incompatible update,
it would probably require bumping the svn revision id numbers.

> 
>>> foo                         foo--20061221151143-50yaxntdektqvtue-1
>>> $ bzr commit
>>> ^^ bzr-svn will assign a different file-id to "foo",
> 
> Why?  SVN doesn't have file-ids, so it can't be intrisic to SVN.  It
> sounds as if bzr-svn is assigning new file-ids for no good reason.


John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFirP/JdeBCYSNAAMRAt6oAJ9tgsWlKnDDD7NfdXwuJM6kjTKTVwCeNjiE
geQjYmTB4YKlVkC5VKGpOEs=
=79pf
-----END PGP SIGNATURE-----