[RFC] Commit Builder restructuring (Re: [RFC] letting the commit builder assign the file ids)

Aaron Bentley aaron.bentley at utoronto.ca
Thu Dec 21 14:29:47 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> Thoughts?

Could you explain why the bzr-svn generates new file ids at commit time?
 Why doesn't it do that when you import a branch from bzr?

> What sort of CommitBuilder API would people like to see?

I think it should be:

CommitBuilder.set_working_tree(wt)
CommitBuilder.set_basis_tree(wt.basis())
for change in wt.logical_compare_to_parents()
    CommitBuilder.record_change(change)
commit()

(Unfortunately, Tree._iter_changes() provides only a subset of the info
needed to do logical_compare_to_parents, because of the last-modified
data we keep about files)

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFFippb0F+nu1YWqI0RAraOAKCFYYB2+phwH7ldhnz8P9VUErHpyACghlT9
1fUy1wl2/2zaNums1/K89YM=
=0LpZ
-----END PGP SIGNATURE-----




More information about the bazaar mailing list