[patch] remove global short-option table

Martin Pool mbp at canonical.com
Wed Dec 20 07:59:31 GMT 2006


On 19 Dec 2006, John A Meinel <john at arbash-meinel.com> wrote:
> John Arbash Meinel has voted +1 (conditional).
> Status is now: Conditionally approved
> Comment:
> It wouldn't be hard to leave the Option.short_name() a function instead of a member, but I don't know that it is needed.

Right, it would be easy to also have a member and the method report on
that, but I think the stability didn't justify the ongoing cruft.

> I was actually thinking that it would probably be nice in the short term to keep a global map, or at least have some way to know when a short option gets re-used for 2 different things. We may want that behavior, but it would be nice to *know* that it has happened, rather than happening accidentally.

I thought it might be nice to do a plugin that lints all the registered
option tables -- for this and also for inconsistent or missing help, etc.

-- 
Martin




More information about the bazaar mailing list