[merge] Ignore write errors when creating hashcache

Aaron Bentley aaron.bentley at utoronto.ca
Tue Dec 19 17:30:17 GMT 2006

Aaron Bentley has voted +1 (conditional).
Status is now: Conditionally approved
This looks reasonable to me.  But
- getattr will raise AttributeError unless you specify a default value.  I think you want getattr(tree, '_hashcache', None)

- I think you should do assertTrue(isinstance(the_hashcache, hashcache.HashCache)), because otherwise the test will appear to succeed.

For details, see: http://bundlebuggy.aaronbentley.com/request/%3C45881DA9.8020204%40arbash-meinel.com%3E

More information about the bazaar mailing list