[MERGE] Bugfix #55276: on win32 cat, bundle and diff commands provide binary output without mangling line-endings

Aaron Bentley aaron.bentley at utoronto.ca
Tue Dec 19 13:54:39 GMT 2006

Aaron Bentley has voted +1.
Status is now: Approved
Looks great.  In terms of English:

When 'encoding_type' attribute of class Command is equal to 'exact', 
force sys.stdout to be a binary stream on Windows, and therefore
keep exact line-endings (without LF -> CRLF conversion).

NOTE: by default on Windows, sys.stdout is opened as a text stream,
therefore LF line-endings are converted to CRLF.
When a command uses encoding_type = 'exact', then
sys.stdout is forced to be a binary stream, and line-endings
will not mangled.

# win32 stdout converts LF to CRLF, and this is breaks the created bundle

# check that output doesn't mangle line-endings

For details, see: http://bundlebuggy.aaronbentley.com/request/%3Cem8igk%24ba8%242%40sea.gmane.org%3E

More information about the bazaar mailing list