[MERGE] alias to respect spaces in quoted arguments (version 3)
Aaron Bentley
aaron.bentley at utoronto.ca
Tue Dec 19 01:39:50 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Marius Kruger wrote:
> thanks, for the vote and the merge.
> sorry about the whitespace (my editor removes it automatically),
> I would have reverted that, but I remembered something on the mailinglist
> about removing all the trailing whitespace, so I removed them.
> I tried to see if you fixed this, but it looks like you forgot.
Well, I did miss some, but I fixed a bunch of them, like the ones in
commands.py, where you changed lines from " " to "".
> 1.) Can we add something to the branch to specify that for certain or
> all files we should
> a.) automatially remove trailing whitespace or
> b.) refuse to commit it.
Usually we add test cases for issues like this. That would suit me fine.
> 2.) Annotate should be able to cope with this. mabye add an option to
> ignore whitespace changes.
No, not without being orders of magnitude slower. Annotate relies on
the fact that knits are a delta-based format whose snapshots are annotated.
For storage purposes, knit deltas must be whitespace-sensitive.
Which means that if annotate is to be whitespace-insensitive, it must
regenerate the annotations from scratch. That's painfully slow. I
wrote the original annotate, before we had a delta-based storage format,
so I know how slow it is.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFh0Lm0F+nu1YWqI0RAp+oAJ0WShr20+aAKJux4tMrpYnw1Rzd3wCfQmms
Xjr4mw0ZQdVCgRCaaznzHkA=
=dZqT
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wsalias.patch
Type: text/x-patch
Size: 5407 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061218/979e09c0/attachment.bin
More information about the bazaar
mailing list